Costumes

jasonteacher · September 17, 2024, 5:26pm

We are having a problem with the Snap! Paint Editor. When we paint a picture and click "ok," it crops up on the right side of the image. When it is opened again, and clicked ok it crops more.

jens · September 17, 2024, 5:30pm

sorry you're encountering this issue. I'm investigating right now, hang on!
Can you perhaps share a project with such a cropped costume in it? That might give me some clues where to look. Tnx!

[edit] nvmd, I can reproduce it. This was introduced yesterday by an optimization supplied by @sarpnt, it seems. I'll revert that and patch it now. In a few minutes it'll be okay again. Sorry, hang on!

jasonteacher · September 17, 2024, 5:34pm

Take the pink square and make it yellow. - Thank you

link

jasonteacher · September 17, 2024, 5:39pm

Thank you for your help. My class will be back on track tomorrow.

jens · September 17, 2024, 5:46pm

I've just fixed this. If you reload Snap! again and use the paint editor to draw a new costume, it should be fine again, no cropping on the right side.

Sorry for disrupting your class with this bug today, and thank you so much for letting me know in time.

sarpnt · September 17, 2024, 8:26pm

augh, one letter typo. i should have just used full words when i wrote it. did too much code golf i guess.

github.com

jmoenig/Snap/blob/0f2ad3a3803af3f4001a267c28175b02eaec5a2a/src/objects.js#L12936


      
              }
              // all the pixels are transparent since the loop went through
              // all of them, this will create a 1x1 costume
              return new Rectangle(0, 0, 1, 1);
          }
          // note that since at least ONE pixel isn't transparent, all of the other
          // loops must finish. Because of this some conditions are left out
          // (if there's a mistake in this code it'll be bad though)
          
          right = (function getRight() {
              for (x = h-1; ; x -= 1) {
                  for (y = 0; y < h; y +=1 ) {
                      if (dta[(x + y * w) * 4 + 3]) {
                          return x + 1;
                      }
                  }
              }
          })();
          
          top = (function getTop() {
              for (y = 0; ; y += 1) {

right crop starts at the costume height, not the costume width.
less important but the next line is formatted wrong.

if i knew you were about to merge it i would have looked over it again! i wouldn't trust any code i wrote nearly 2 years ago. i've been cleaning up similar bad code in my own projects too.

(i should clarify this is the obvious mistake, i didn't fully test it just now to make sure it works fine after fixing that and i'm not suggesting you put it back in yet)